Implement a lazy representation of a list of sliding windows #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdeelH
force-pushed
the
sliding_windows
branch
2 times, most recently
from
b9b2394
to
17dd27f
Compare
allowing arbitrarily long lists of sliding windows (from arbitrarily large extents) to be represented
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
- Coverage 90.31% 90.29% -0.03%
==========================================
Files 199 199
Lines 9925 9965 +40
==========================================
+ Hits 8964 8998 +34
- Misses 961 967 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a lazy representation of a list of sliding windows allowing arbitrarily long lists of sliding windows (from arbitrarily large extents) to be represented.
Previously,
Box.get_window()would return alist[Box], which could be very large if there were a lot of windows. Now, it returns aSlidingWindowsobject that can be indexed like a list and generates windows dynamically when indexed.Checklist
[ ] Addedneeds-backportlabel if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
See unit tests.